fix(bridge): fix test isolation for nudge_counter test#365
Open
fix(bridge): fix test isolation for nudge_counter test#365
Conversation
Add fs::remove_dir_all before ensure_dirs in three dispatch tests to clean up stale state from previous runs. Without this, leftover nudge_ts files cause cooldown checks to suppress nudge emission, making the test fail with "should produce nudge" assertion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post_tool_use_increments_nudge_countertest fails because stalenudge_tsfiles from previous runs cause cooldown suppression, preventing nudge emission.fs::remove_dir_allcleanup beforeensure_dirsin three tests:post_tool_use_cooldown_suppresses,post_tool_use_increments_nudge_counter, andpost_tool_use_increments_decide_counter.counter_increment_and_read(line 1030).Test plan
cargo test -p edda-bridge-claude --lib -- post_tool_use_increments_nudge_counterpassescargo test -p edda-bridge-claude --lib -- post_tool_use_cooldown_suppressespassescargo test -p edda-bridge-claude --lib -- post_tool_use_increments_decide_counterpasses🤖 Generated with Claude Code